stevedlawrence commented on code in PR #812:
URL: https://github.com/apache/daffodil/pull/812#discussion_r923537699


##########
build.sbt:
##########
@@ -57,6 +57,7 @@ lazy val io               = Project("daffodil-io", 
file("daffodil-io")).configs(
 lazy val runtime1         = Project("daffodil-runtime1", 
file("daffodil-runtime1")).configs(IntegrationTest)
                               .dependsOn(io, lib % "test->test", udf, macroLib 
% "compile-internal, test-internal")
                               .settings(commonSettings, usesMacros)
+                              .settings(libraryDependencies ++= 
Dependencies.exi)

Review Comment:
   I wonder if there is value is splitting all of our infoset 
inputters/outputters into separate subprojects with separate dependencies? That 
way our runtime doesn't depend on a bunch of different libraries, many of which 
wouldn't be used.
   
   This means API users would need to add a new dependency depending on which 
infoset they want to use (e.g. daffodil-runtime1-infoset-xml, 
daffodil-runtime-infoset-json, daffodil-runtime1-infoset-sax), but it makes 
runtime and it's dependencies smaller.
   
   We could still have the CLI depend on all or a subset of these for which 
ever infoset inputters we want to make available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to