jadams-tresys commented on code in PR #812:
URL: https://github.com/apache/daffodil/pull/812#discussion_r923601724


##########
build.sbt:
##########
@@ -57,6 +57,7 @@ lazy val io               = Project("daffodil-io", 
file("daffodil-io")).configs(
 lazy val runtime1         = Project("daffodil-runtime1", 
file("daffodil-runtime1")).configs(IntegrationTest)
                               .dependsOn(io, lib % "test->test", udf, macroLib 
% "compile-internal, test-internal")
                               .settings(commonSettings, usesMacros)
+                              .settings(libraryDependencies ++= 
Dependencies.exi)

Review Comment:
   I'm not sure that I like the idea of moving those 3 infoset 
inputters/outputter into a separate library.  I think Daffodil should have some 
subset of infoset handlers built in (the most common, which I would assume to 
be these 3) and then perhaps the other less common infoset implementations 
could be set up as separate libraries?  I know it's not exactly the most 
consistent design, but it would feel strange to me to not include such basic 
functionality in the main Daffodil library.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to