jadams-tresys commented on code in PR #812:
URL: https://github.com/apache/daffodil/pull/812#discussion_r923606379
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -1400,8 +1408,15 @@ object Main {
private def unparseWithSAX(
is: InputStream,
- contentHandler: DFDL.DaffodilUnparseContentHandler): UnparseResult = {
- val xmlReader = DaffodilSAXParserFactory().newSAXParser.getXMLReader
+ contentHandler: DFDL.DaffodilUnparseContentHandler,
+ infosetType: InfosetType.Type): UnparseResult = {
+ val xmlReader = infosetType match {
+ case InfosetType.EXI => {
+ val exiSource = new EXISource()
+ exiSource.getXMLReader
+ }
+ case _ => DaffodilSAXParserFactory().newSAXParser.getXMLReader
+ }
Review Comment:
I'm open to ideas on this one. @mbeckerle seemed more interested in relying
on the SAX handlers. It's probably worth it for me to do some performance
testing to see how performance is with this current SAX/EXI code. If we aren't
seeing any significant performance improvements, perhaps it would be worth it
to use EXI directly in a more traditional Infoset inputter/outputter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
