mike-mcgann commented on code in PR #898:
URL: https://github.com/apache/daffodil/pull/898#discussion_r1054451144


##########
daffodil-test/src/test/resources/org/apache/daffodil/usertests/SepTests.tdml:
##########
@@ -194,11 +194,7 @@
       representation="text"
       lengthKind="delimited"
       separatorPosition="infix"
-      dfdlx:emptyElementParsePolicy="treatAsEmpty"/><!-- remove extension 
proerty for IBM cross tests -->
-    <!--
-    Note: dfdlx:emptyElementParsePolicy should become regular DFDL 
emptyElementParsePolicy
-    once implemented in DAFFODIL-2496. The enum 'treatAsMissing' is renamed to 
'treatAsAbsent'
-    -->
+      emptyElementParsePolicy="treatAsEmpty"/><!-- remove extension property 
for IBM cross tests -->

Review Comment:
   I refactored this a bit.
   
   Schema 4 now uses the old dfdlx:emptyElementParsePolicy and the IBM test for 
that is the same as before. I added a new test for daffodil only that checks 
that a parse error and a deprecation warning is issued. 
   
   Schema 5 uses the new dfdl:emptyElementParsePolicy and that test only runs 
on daffodil. I'm not sure what happens on IBM for that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to