stevedlawrence commented on code in PR #898:
URL: https://github.com/apache/daffodil/pull/898#discussion_r1054452588
##########
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dfdlx.xsd:
##########
@@ -99,6 +99,7 @@
<xs:restriction base="xs:string">
<xs:enumeration value="treatAsEmpty" />
<xs:enumeration value="treatAsMissing" />
+ <xs:enumeration value="treatAsAbsent" />
Review Comment:
I think I'm still confused.
I understand why ByHandMixin.scala needs all three enumerations since both
dfdl and dfdlx properties use the same EmptyElementParsePolicy object to
convert a string to the type.
> but the property generator fabricates variables using the unprefixed name
The property generator excludes the EmptyElementParsePolicy type, so doesn't
it completely ignore the definitions in this dfdlx.xsd file? So aren't the
enumerations in this file just about doing DFDL schema validation and nothing
else? And since treatAsAbsent isn't valid in he dfdlx property shouldn't it be
removed here and only be defined in the DFDL_partX xsd file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
