stevedlawrence commented on code in PR #898:
URL: https://github.com/apache/daffodil/pull/898#discussion_r1054524031
##########
daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixins.scala:
##########
@@ -432,7 +432,9 @@ sealed trait EmptyElementParsePolicy extends
EmptyElementParsePolicy.Value
object EmptyElementParsePolicy extends Enum[EmptyElementParsePolicy] {
case object TreatAsMissing extends EmptyElementParsePolicy
case object TreatAsEmpty extends EmptyElementParsePolicy
- override lazy val values = Array(TreatAsMissing, TreatAsEmpty)
+ case object TreatAsAbsent extends EmptyElementParsePolicy
+
+ override lazy val values = Array(TreatAsMissing, TreatAsEmpty, TreatAsAbsent)
def apply(name: String, context: ThrowsSDE): EmptyElementParsePolicy =
stringToEnum("emptyElementParsePolicy", name, context)
Review Comment:
DFDLGeneralFormat.dfdl.xsd is a thing Daffodil invented, I don't think IBM
has any concept of it. DFDL schemas use the full path of
`org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd `, which is daffodil
specific and what the cross tester will use since that is what schemas import.
I guess we do have two different defineFormats: `DFDLGeneralFormat` and
`DFDLGeneralFormatPortable`. We could put the new property in the
DFDLGeneralFormat define, but many schemas (including most of our tests) don't
use the "portable" variant and will probably fail if cross tested. Maybe that's
okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
