stevedlawrence commented on code in PR #898:
URL: https://github.com/apache/daffodil/pull/898#discussion_r1054499855
##########
daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixins.scala:
##########
@@ -432,7 +432,9 @@ sealed trait EmptyElementParsePolicy extends
EmptyElementParsePolicy.Value
object EmptyElementParsePolicy extends Enum[EmptyElementParsePolicy] {
case object TreatAsMissing extends EmptyElementParsePolicy
case object TreatAsEmpty extends EmptyElementParsePolicy
- override lazy val values = Array(TreatAsMissing, TreatAsEmpty)
+ case object TreatAsAbsent extends EmptyElementParsePolicy
+
+ override lazy val values = Array(TreatAsMissing, TreatAsEmpty, TreatAsAbsent)
def apply(name: String, context: ThrowsSDE): EmptyElementParsePolicy =
stringToEnum("emptyElementParsePolicy", name, context)
Review Comment:
> we want to add the property to DFDLGeneralFormat.dfdl.xsd and give it the
same 'treatAsEmpty' default value.
I just thought of one potential issue when adding to DFDLGeneralFormat. If
IBM DFDL doesn't support this new property then any schemas that used
DFDLGeneralFormat.dfdl.xsd might now error when cross run with IBM? To ensure
backwards compat, maybe we don't want to add the property to the file,
especially since it's optional (as Mike says) and we already have built in
defaulting behavior? Though as you point out, that would mean lots of schemas
would need to manually add this property to suppress the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
