mike-mcgann opened a new pull request, #919:
URL: https://github.com/apache/daffodil/pull/919

   This is just a draft so I can get feedback on the refactoring. To see a 
preview of the changes, get the code from this branch and refactor by running 
the following script:
   
   ```
   xsrc/test/scripts/refactor/refactor.sh
   ```
   
   Undo the changes with:
   
   ```
   xsrc/test/scripts/refactor/git-restore.sh
   ```
   
   These files were originally in the `src` directory but the build for 
runtime2 fails if the directory is named `src`.
   
   The package mappings can be found here:
   
   
https://github.com/mike-mcgann/daffodil/blob/daffodil-2683-unsplit-packages/xsrc/test/scripts/refactor/fix-imports.scala#L11-L18
   
   runtime1-layers became layers.runtime1 so that it doesn't interfere with 
runtime1.layers. I wasn't sure what was best here and this can be renamed to 
something clearer if desired.
   
   Java service registrations that rely on class name also had to change and 
this likely introduces a breaking change. Should we make this change or should 
we try to preserve the original name in some way?
   
   [DAFFODIL-2683](https://issues.apache.org/jira/browse/DAFFODIL-2683)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to