mbeckerle commented on code in PR #919:
URL: https://github.com/apache/daffodil/pull/919#discussion_r1081349757
##########
xsrc/test/scripts/refactor/lint-split-packages.scala:
##########
@@ -0,0 +1,62 @@
+// import java.nio.file.Path
Review Comment:
keeping this why? It's ok, just put comment at the top as to why.
##########
xsrc/test/scripts/refactor/fix-imports.scala:
##########
@@ -0,0 +1,184 @@
+import java.io.BufferedWriter
+import java.io.FileWriter
+import java.io.File
+import scala.collection.mutable.ListBuffer
+import scala.collection.mutable.Map
+import scala.io.Source
+
+object FixImports extends App {
+ val inline = true
+ val importMap = Map(
+ "daffodil-cli" -> "cli",
+ "daffodil-core" -> "core",
+ "daffodil-io" -> "io",
+ "daffodil-lib" -> "lib",
+ "daffodil-macro-lib" -> "lib",
+ "daffodil-runtime1" -> "runtime1",
+ "daffodil-runtime1-layers" -> "layers.runtime1",
+ "daffodil-runtime1-unparser" -> "unparsers.runtime1"
Review Comment:
Core is the short name for the primary "schema compiler" module currently. I
think using core for the compiler aspects of other modules is fine.
Maybe everything "core" should be renamed "comp" instead though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
