mike-mcgann commented on code in PR #919:
URL: https://github.com/apache/daffodil/pull/919#discussion_r1084491556
##########
xsrc/test/scripts/refactor/rename-dirs.sh:
##########
@@ -0,0 +1,106 @@
+#!/bin/bash
Review Comment:
> 2. The output from the bash scripts will be easier to understand if you
run them with #!/bin/bash -x, so I've suggested these changes below.
All the bash scripts should be updated with -ex and the main refactor.sh
calls them using the shebang instead of explicitly through bash.
> 3. The scripts changed the packages of the src/it tests. I think their
packages should have stayed the same since no one ever packages test classes in
jars:
This got refactored in another commit so I think this has been overcome by
events.
> 7. I ran sbt IntegrationTest/test and it failed immediately:
The reference in the documentation has been updated along with the main
class reference in the templates.
> 8. I ran sbt ratCheck and it failed (the 11 licenses were the files in
xsrc/test/refactor/scripts and the 5 binaries were files that weren't
recognized as AL after the scripts changed them):
I added licenses where they were missing. I do not know how to fix the
services files into being recognized as text. I cannot seem to find where this
is set in this codebase and looking at the rat repository didn't help either.
Any help here would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
