stevedlawrence commented on code in PR #919:
URL: https://github.com/apache/daffodil/pull/919#discussion_r1081285116
##########
xsrc/test/scripts/refactor/fix-imports.scala:
##########
@@ -0,0 +1,184 @@
+import java.io.BufferedWriter
+import java.io.FileWriter
+import java.io.File
+import scala.collection.mutable.ListBuffer
+import scala.collection.mutable.Map
+import scala.io.Source
+
+object FixImports extends App {
+ val inline = true
+ val importMap = Map(
+ "daffodil-cli" -> "cli",
+ "daffodil-core" -> "core",
+ "daffodil-io" -> "io",
+ "daffodil-lib" -> "lib",
+ "daffodil-macro-lib" -> "lib",
+ "daffodil-runtime1" -> "runtime1",
+ "daffodil-runtime1-layers" -> "layers.runtime1",
+ "daffodil-runtime1-unparser" -> "unparsers.runtime1"
Review Comment:
Maybe runtime1 wants to be `org.apache.daffodil.runtime1.core` or
`org.apache.daffodil.runtime1.parsers`? That way all the runtime1 stuff are in
subpackages of the same parent package.
##########
xsrc/test/scripts/refactor/fix-imports.scala:
##########
@@ -0,0 +1,184 @@
+import java.io.BufferedWriter
+import java.io.FileWriter
+import java.io.File
+import scala.collection.mutable.ListBuffer
+import scala.collection.mutable.Map
+import scala.io.Source
+
+object FixImports extends App {
+ val inline = true
+ val importMap = Map(
+ "daffodil-cli" -> "cli",
+ "daffodil-core" -> "core",
+ "daffodil-io" -> "io",
+ "daffodil-lib" -> "lib",
+ "daffodil-macro-lib" -> "lib",
Review Comment:
This might want to be `org.apache.daffodil.macros`? This package isn't
actually published anywhere so it probably doesn't really matter, but it might
help to make it more clear in the codebase where macros are actually used if
they are in a separate namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
