tuxji commented on PR #919: URL: https://github.com/apache/daffodil/pull/919#issuecomment-1416035909
Splitting the PR into two commits with all the move/rename changes in their own separate commit and [ignoring that commit in the blame view](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view) sounds good to me. For the purpose of the git blame view, I think it makes sense to include the FieldFinder, TestFieldFinder, and Rat.scala changes in the move/rename commit and put the build.sbt & OsgiCheck.scala changes in the scripts commit. However, we need to do the move/rename changes in the first commit because we need to put the move/rename commit's hash in the .git-blame-ignore-revs file. @mike-mcgann, can you run the necessary git fetch/git rebase -i/git push --force-with-lease commands to rearrange your PR into that order (first commit doing the move/rename changes, second commit saving the scripts and putting the first commit's hash in .git-blame-ignore-revs)? Then we can review the PR for final approval before merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
