mbeckerle commented on code in PR #975:
URL: https://github.com/apache/daffodil/pull/975#discussion_r1123536249
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -131,6 +133,15 @@ sealed abstract class GlobalGroupDef(
}
}
+ private def checkForGroupDefAnnotations(): Unit = {
+ // Ensure that the group definition itself does not have any annotations.
+ // Annotations should only be on group references or children of the group
+ // definition
+ val found = defXML.child.map(_.label).contains("annotation")
Review Comment:
Suggest make dfdlAppInfos return a `Either[Seq[(WarnID, String)],
Seq[DFDLAppInfo]]`
where Left is warnings to issue, Right is the appinfo object(s) if all goes
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
