stevedlawrence commented on code in PR #975:
URL: https://github.com/apache/daffodil/pull/975#discussion_r1123578451
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -131,6 +133,15 @@ sealed abstract class GlobalGroupDef(
}
}
+ private def checkForGroupDefAnnotations(): Unit = {
+ // Ensure that the group definition itself does not have any annotations.
+ // Annotations should only be on group references or children of the group
+ // definition
+ val found = defXML.child.map(_.label).contains("annotation")
Review Comment:
Maybe another alternative, doesn't `GlobalGroupDef` implement
`AnnotatedSchemaComponet` so it has access to dfdlAppInfos? Can the new check
function just do something like:
```scala
if (dfdlAppInfos.length > 0) SDW(...)
```
So you reuse the existing dfdlAppInfos logic to find any dfdl annotations
(which might warn), but then we can warn that they will be ignored in the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
