tuxji commented on code in PR #975:
URL: https://github.com/apache/daffodil/pull/975#discussion_r1123866451
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -131,6 +133,18 @@ sealed abstract class GlobalGroupDef(
}
}
+ private def checkForGroupDefAnnotations(): Unit = {
+ // Ensure that the group definition itself does not have any annotations.
+ // Annotations should only be on group references or children of the group
+ // definition
+ val dais = getDFDLAppinfos(defXML \ "annotation" \ "appinfo")
+ if (dais.nonEmpty)
+ SDW(
+ WarnID.InvalidAnnotationPoint,
+ "Annotations placed directly on a group definition will be ignored by
DFDL. Any annotation expected to be processed by DFDL should instead be placed
on the group reference",
Review Comment:
Saying "or model group" may confuse a user who isn't familiar with the
meaning of "model group." I suggest either leaving the message the way it is
now or changing it to `... should be placed on the group reference, choice, or
sequence` if we really want to list all the possible places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
