stevedlawrence commented on code in PR #975:
URL: https://github.com/apache/daffodil/pull/975#discussion_r1123646006
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -131,6 +133,15 @@ sealed abstract class GlobalGroupDef(
}
}
+ private def checkForGroupDefAnnotations(): Unit = {
+ // Ensure that the group definition itself does not have any annotations.
+ // Annotations should only be on group references or children of the group
+ // definition
+ val found = defXML.child.map(_.label).contains("annotation")
Review Comment:
I see. Maybe instead of making it an `XMLUtils` function it becomes a public
function in `AnnotatedMixin` that accepts the XML node to look for annotations
as a paramter? This way it could still create warnings like normal, and
dfdlAppInfo could pass in `xml` while the GroupDef check could pass in
`defXML`? Just trying to avoid having a complex return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
