olabusayoT commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1752431067
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -1330,6 +1415,14 @@ case class ParserTestCase(ptc: NodeSeq, parentArg:
DFDLTestSuite)
roundTrip match {
case NoRoundTrip | OnePassRoundTrip => {
+ val allDiags = firstParseResult.getDiagnostics ++ compileWarnings
+ checkDiagnosticMessages(
+ allDiags,
+ Seq.empty,
+ optWarnings = warnings,
+ optValidationErrors = validationErrors,
+ implString = implString)
+
verifyParseResults(compileWarnings, firstParseResult, testInfoset,
implString)
Review Comment:
You're right...It looks like we only need it for onePass, since it's the
only one that doesn't call verifyParseResults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
