olabusayoT commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1757354907
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -959,32 +990,45 @@ abstract class TestCase(testCaseXML: NodeSeq, val parent:
DFDLTestSuite) {
protected def checkDiagnosticMessages(
diagnostics: Seq[Diagnostic],
- errors: ExpectedErrors,
- optWarnings: Option[ExpectedWarnings],
+ errors: Seq[ExpectedErrors],
Review Comment:
Yes, making that change will allow us to call checkDiagnosticMessages
everywhere we currently call verifyDiagnosticsFound. We would just pass in None
for what we don't wish to check.
Ex to check only warnings or only validationErrors, we do
```
checkDiagnosticMessages(
allDiags,
None,
optWarnings,
None,
implString
)
//or
checkDiagnosticMessages(
actual.getDiagnostics,
None,
None,
optValidationErrors,
implString
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
