stevedlawrence commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1755008118
##########
daffodil-test/src/test/resources/org/apache/daffodil/section02/validation_errors/Validation.tdml:
##########
@@ -1902,7 +1902,7 @@
<!-- Validation error for branch1:e1 -->
<tdml:error>Validation Error</tdml:error>
- <tdml:error>nonNegA failed facet checks due to: facet minInclusive
(30)</tdml:error>
+ <tdml:error>e1 failed facet checks due to: facet minInclusive
(30)</tdml:error>
Review Comment:
I just noticed that this test expects `<tdml:errors>`. Does it even make
sense to expect validation errors if we don't even get an infoset? I wonder if
this was just previously ignored since the tests didn't expect success? Should
the expected validationErrors just be removed here, and in general
tdml:validationErrors + tdml:errors in the same test should maybe be an
TDMLException? We can open a bug for that if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
