olabusayoT commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1755081803


##########
daffodil-test/src/test/resources/org/apache/daffodil/section02/validation_errors/Validation.tdml:
##########
@@ -1902,7 +1902,7 @@
         
       <!-- Validation error for branch1:e1  -->
       <tdml:error>Validation Error</tdml:error>
-      <tdml:error>nonNegA failed facet checks due to: facet minInclusive 
(30)</tdml:error>
+      <tdml:error>e1 failed facet checks due to: facet minInclusive 
(30)</tdml:error>

Review Comment:
   Good point, I did just add validationErrors to checkDiagnostics, which 
explains why the test just now failed.
   
   I think it makes sense to make validationErrors errors in the same test a 
TDMLException in a future PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to