olabusayoT commented on code in PR #1455:
URL: https://github.com/apache/daffodil/pull/1455#discussion_r1992393318
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/CompiledExpression.scala:
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.runtime1.dsom._
import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive
object ExpressionCompilers extends ExpressionCompilerClass {
- override val String = new ExpressionCompiler[String]
- override val JLong = new ExpressionCompiler[JLong]
- override val AnyRef = new ExpressionCompiler[AnyRef]
- override val JBoolean = new ExpressionCompiler[JBoolean]
+ override val String: ExpressionCompiler[String] = new
ExpressionCompiler[String]
+ override val JLong: ExpressionCompiler[JLong] = new ExpressionCompiler[JLong]
+ override val AnyRef: ExpressionCompiler[AnyRef] = new
ExpressionCompiler[AnyRef]
+ override val JBoolean: ExpressionCompiler[JBoolean] = new
ExpressionCompiler[JBoolean]
Review Comment:
Right, I've had to set explicit types in a bunch of places otherwise the
compiler complains about a type mismatch or an incompaible type
As an example his is from the Scala 3 migration guide:
https://docs.scala-lang.org/scala3/guides/migration/incompat-type-inference.html
"In Scala 3 the return type of an override method is inferred by inheritance
from the base method, whereas in Scala 2.13 it is inferred from the left hand
side of the override method."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
