mbeckerle commented on code in PR #1455:
URL: https://github.com/apache/daffodil/pull/1455#discussion_r1993575784
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/CompiledExpression.scala:
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.runtime1.dsom._
import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive
object ExpressionCompilers extends ExpressionCompilerClass {
- override val String = new ExpressionCompiler[String]
- override val JLong = new ExpressionCompiler[JLong]
- override val AnyRef = new ExpressionCompiler[AnyRef]
- override val JBoolean = new ExpressionCompiler[JBoolean]
+ override val String: ExpressionCompiler[String] = new
ExpressionCompiler[String]
+ override val JLong: ExpressionCompiler[JLong] = new ExpressionCompiler[JLong]
+ override val AnyRef: ExpressionCompiler[AnyRef] = new
ExpressionCompiler[AnyRef]
+ override val JBoolean: ExpressionCompiler[JBoolean] = new
ExpressionCompiler[JBoolean]
Review Comment:
I hate this crap. Java style being enforced on scala code. Having to state
the type twice on the same line of code is well,... barfy java stuff.
In this case, I suggest dropping the overrides by merging this object with
the ExpressionCompilersClass base. That is used in exactly one place. Might as
well just pass the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
