mbeckerle commented on code in PR #1455:
URL: https://github.com/apache/daffodil/pull/1455#discussion_r1998984455
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/CompiledExpression.scala:
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.runtime1.dsom._
import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive
object ExpressionCompilers extends ExpressionCompilerClass {
- override val String = new ExpressionCompiler[String]
- override val JLong = new ExpressionCompiler[JLong]
- override val AnyRef = new ExpressionCompiler[AnyRef]
- override val JBoolean = new ExpressionCompiler[JBoolean]
+ override val String: ExpressionCompiler[String] = new
ExpressionCompiler[String]
+ override val JLong: ExpressionCompiler[JLong] = new ExpressionCompiler[JLong]
+ override val AnyRef: ExpressionCompiler[AnyRef] = new
ExpressionCompiler[AnyRef]
+ override val JBoolean: ExpressionCompiler[JBoolean] = new
ExpressionCompiler[JBoolean]
Review Comment:
Ah. This stuff again. This split between runtime1 and core needs to be
revisited at some point it's not a stable division of the modules. So I guess
the repetitiveness in type signatures is needed because of the module split
then. Oh well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
