olabusayoT commented on code in PR #1455:
URL: https://github.com/apache/daffodil/pull/1455#discussion_r1996289344
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/CompiledExpression.scala:
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.runtime1.dsom._
import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive
object ExpressionCompilers extends ExpressionCompilerClass {
- override val String = new ExpressionCompiler[String]
- override val JLong = new ExpressionCompiler[JLong]
- override val AnyRef = new ExpressionCompiler[AnyRef]
- override val JBoolean = new ExpressionCompiler[JBoolean]
+ override val String: ExpressionCompiler[String] = new
ExpressionCompiler[String]
+ override val JLong: ExpressionCompiler[JLong] = new ExpressionCompiler[JLong]
+ override val AnyRef: ExpressionCompiler[AnyRef] = new
ExpressionCompiler[AnyRef]
+ override val JBoolean: ExpressionCompiler[JBoolean] = new
ExpressionCompiler[JBoolean]
Review Comment:
I don't think it's at straightfoward as merging the object (which is in
core) with the ExpressionCompilerClass base (which is in runtime1).
ExpressionCompilerClass wont have access to the ExpressionCompiler class in
core, unless you want me to merge the ExpressionCompiler class with it's own
base?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
