davecromberge commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r452902752
##########
File path:
src/main/java/org/apache/datasketches/BoundsOnRatiosInSampledSets.java
##########
@@ -82,6 +82,28 @@ public static double getEstimateOfBoverA(final long a, final
long b) {
return (double) b / a;
}
+ /**
+ * Return the estimate of A. See class javadoc.
+ * @param a See class javadoc
+ * @param f the inclusion probability used to produce the set with size
<i>a</i>.
+ * @return the approximate lower bound
+ */
+ public static double getEstimateOfA(final long a, final double f) {
+ checkInputs(a, 1, f);
+ return a / f;
+ }
+
+ /**
+ * Return the estimate of B. See class javadoc.
+ * @param b See class javadoc
+ * @param f the inclusion probability used to produce the set with size
<i>a</i>.
Review comment:
Thank you for addressing my concerns about serialisation - your answer
also cleared my misconceptions about the library version being tied to the
serialisation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
