leerho commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r452628457
##########
File path: src/main/java/org/apache/datasketches/theta/IntersectionImplR.java
##########
@@ -82,15 +83,15 @@
}
}
- IntersectionImplR(final short seedHash) {
- seedHash_ = seedHash;
- mem_ = null;
- lgArrLongs_ = 0;
- curCount_ = -1;
- thetaLong_ = Long.MAX_VALUE;
- empty_ = false;
- hashTable_ = null;
- }
+ // IntersectionImplR(final short seedHash) {
+ // seedHash_ = seedHash;
+ // mem_ = null;
+ // lgArrLongs_ = 0;
+ // curCount_ = -1;
+ // thetaLong_ = Long.MAX_VALUE;
+ // empty_ = false;
+ // hashTable_ = null;
+ // }
Review comment:
Yes. It was placed there at one time when we thought we needed it. But
nothing calls it, it is dead code. I left it there in case I thought of
another reason to put it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
