davecromberge commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r452913393
##########
File path: src/main/java/org/apache/datasketches/tuple/CompactSketch.java
##########
@@ -121,6 +121,11 @@
}
}
+ @Override
+ public CompactSketch<S> compact() {
+ return this;
+ }
Review comment:
Great - just to add some detail - it is possible now to compute this by
serialising the sketch and measuring the resulting byte size. However, this is
obviously wasteful and my question above is only predicated on whether the
internal bytes are already available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
