leerho opened a new pull request, #516: URL: https://github.com/apache/datasketches-java/pull/516
While analyzing Issue 514, I realized that adding a few new asserts and/or exceptions would be very helpful to users and to us when debugging. Specifically, they consist of 3 different detections: - Throwing an exception if a self-merge is detected. This is an easy-to-make user error and warrants an exception. These next two should be very rare, but are also directly in the update path, so I think an _assert_ is more appropriate. - Throwing an AssertionError if N (the number of items input into the sketch) exceeds Long.MAX_VALUE. - Throwing an AssertionError if the number of levels exceed 60 I also realized that our built-in shuffle class could be improved by allowing generic arrays to be shuffled and also providing the option of a user-provided Random generator instead of only the internal default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
