leerho commented on PR #516: URL: https://github.com/apache/datasketches-java/pull/516#issuecomment-1977756056
This is a tough one. I discovered these issues while running malformed test code. In all three cases, the sketch crashes. If the user just runs their environment with "-ea" enabled, the asserts will run. Changing the asserts to exceptions means running a check always for a situation that should be exceedingly rare and is in the direct path of every insertion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
