leerho commented on PR #516: URL: https://github.com/apache/datasketches-java/pull/516#issuecomment-1977764690
This is a tough one. I discovered these issues running buggy test code. In the two assert cases the sketch will crash without any checks. If the user reruns the environment with"-ea" the asserts will display the meaningful error message. Converting to exceptions means the checks will always run for what should be extremely rare situations. I hesitate to put too many checks directly in the update path. There are many, many places in our code where we use longs and do not check for overflow, because longs are so huge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
