jmalkin commented on PR #516: URL: https://github.com/apache/datasketches-java/pull/516#issuecomment-1975908971
I'm not sure about the assert. Aren't those removed for non-debug builds? Meaning the use cases where we'd expect the asserts to possibly trigger are likely to be the situations where the assert is removed? I don't think we'd expect people to insert that many items into a debug-mode test. The changes are fine if we agree it's ok not to have those check in productions systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
