e2corporation commented on code in PR #3371:
URL: https://github.com/apache/incubator-devlake/pull/3371#discussion_r992483465
##########
config-ui/src/hooks/useDataScopesManager.jsx:
##########
@@ -26,6 +26,7 @@ import GitlabProject from '@/models/GitlabProject'
import { ProviderIcons, ProviderLabels, Providers } from '@/data/Providers'
import { DataScopeModes } from '@/data/DataScopes'
import JenkinsJob from '@/models/JenkinsJob'
+import useTransformationsManager from
'@/hooks/data-scope/useTransformationsManager'
Review Comment:
The reason I placed transformation logic in the DSM Hook is because
DataScopes are at the highest level and encompasses transformation Logic. The
other alternative is to make the Transformation Manager a non-react pure JS
Utility with logic ported to accomplish the same goals (under `utils/`).
Wait till I verify that this is truly a Hook violation first before
refactoring again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
