[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3371: add transformations hook to write all logic about it in one file.

Tue, 11 Oct 2022 08:53:28 -0700 


likyh commented on code in PR #3371:
URL: https://github.com/apache/incubator-devlake/pull/3371#discussion_r992505499


##########
config-ui/src/hooks/useDataScopesManager.jsx:
##########
@@ -26,6 +26,7 @@ import GitlabProject from '@/models/GitlabProject'
 import { ProviderIcons, ProviderLabels, Providers } from '@/data/Providers'
 import { DataScopeModes } from '@/data/DataScopes'
 import JenkinsJob from '@/models/JenkinsJob'
+import useTransformationsManager from 
'@/hooks/data-scope/useTransformationsManager'

Review Comment:
   
![image](https://user-images.githubusercontent.com/3294100/195138785-b0177a96-d9f3-4685-befa-ee0b2db254c8.png)
   
   No. I think the hook is used maybe a good practice like `useRoute` or others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to