[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3371: add transformations hook to write all logic about it in one file.

Tue, 11 Oct 2022 08:52:13 -0700 


e2corporation commented on code in PR #3371:
URL: https://github.com/apache/incubator-devlake/pull/3371#discussion_r992509058


##########
config-ui/src/pages/blueprints/create-blueprint.jsx:
##########
@@ -904,57 +879,18 @@ const CreateBlueprint = (props) => {
     dataEntities,
     boards,
     projects,
-    transformations,
     validatePipeline,
     createProviderScopes,
     setBlueprintSettings
   ])
 
-  useEffect(() => {

Review Comment:
   This logic should have already been commented out/removed at one point and 
replaced by the logic moved to the DSM Hook. Not sure why it's still intact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to