e2corporation commented on code in PR #3371:
URL: https://github.com/apache/incubator-devlake/pull/3371#discussion_r992506738
##########
config-ui/src/pages/blueprints/create-blueprint.jsx:
##########
@@ -613,28 +607,10 @@ const CreateBlueprint = (props) => {
setConnectionDialogIsOpen(true)
}, [])
- // @note: replaced by definition in dsm hook!
- // const setTransformationSettings = useCallback(
- // (settings, configuredEntity) => {
- // console.log(
- // '>> SETTING TRANSFORMATION SETTINGS PROJECT/BOARD...',
- // configuredEntity,
- // settings
- // )
- // setTransformations((existingTransformations) => ({
- // ...existingTransformations,
- // [configuredEntity]: {
- // ...existingTransformations[configuredEntity],
- // ...settings,
- // },
- // }))
- // },
- // [setTransformations]
- // )
-
const handleTransformationSave = useCallback(
(settings, entity) => {
console.log('>> SAVING / CLOSING Transformation Settings')
+ // FIXME what's this???
Review Comment:
There's nothing to `Fix` here, this is a comment/reminder to indicate that
at one point UI requirements wanted a **Save** Button, which means that we only
write new transformations when save is clicked, however existing form controls
are reactive so transformations are written/stored when **typed**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
