chris-fast opened a new pull request, #17909: URL: https://github.com/apache/dolphinscheduler/pull/17909
## What is the purpose of the change Fixes #17908 The `-sae` (--shutdownOnAttachedExit) parameter causes Flink tasks in YARN Application mode to terminate unexpectedly after a few minutes. This parameter is only suitable for attached mode where the CLI stays connected, but Application mode runs in detached mode. ## Root Cause When submitting Flink jobs in YARN Application mode: - The Flink CLI exits after submission (detached mode) - The `-sae` parameter triggers cluster shutdown when CLI terminates - This causes the YARN application to be killed unexpectedly ## Brief changelog - Modified `FlinkArgsUtils.buildRunCommandLineForOthers()` to only add `-sae` parameter for non-APPLICATION deploy modes - Updated test cases in `FlinkArgsUtilsTest` for both flink and flink-stream modules ## Verifying this change - [x] Code compilation pass - [x] Unit tests updated to reflect the new behavior - [x] Follows the project's code style ### Test Cases Behavior **Before the fix:** ``` flink run-application -t yarn-application ... -sae ... # ❌ Causes unexpected termination ``` **After the fix:** ``` flink run-application -t yarn-application ... # ✅ No -sae parameter flink run -t yarn-per-job ... -sae ... # ✅ Still has -sae flink run ... -sae ... # ✅ Still has -sae ``` ## Related issues Fixes #17908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
