SbloodyS commented on code in PR #17909:
URL:
https://github.com/apache/dolphinscheduler/pull/17909#discussion_r2731196266
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java:
##########
@@ -267,7 +267,10 @@ private static List<String>
buildRunCommandLineForOthers(TaskExecutionContext ta
// If the job is submitted in attached mode, perform a best-effort
cluster shutdown when the CLI is terminated
// abruptly
// The task status will be synchronized with the cluster job status
- args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT); // -sae
+ // Note: -sae should NOT be used for APPLICATION mode, as it runs in
detached mode on YARN
+ if (deployMode != FlinkDeployMode.APPLICATION) {
+ args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT); // -sae
+ }
Review Comment:
We should make it configurable in UI and set it as off by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
