SbloodyS commented on code in PR #17909:
URL:
https://github.com/apache/dolphinscheduler/pull/17909#discussion_r2739387507
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java:
##########
@@ -267,7 +267,10 @@ private static List<String>
buildRunCommandLineForOthers(TaskExecutionContext ta
// If the job is submitted in attached mode, perform a best-effort
cluster shutdown when the CLI is terminated
// abruptly
// The task status will be synchronized with the cluster job status
- args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT); // -sae
+ // Note: This parameter is now configurable via UI, default is false
(disabled)
Review Comment:
```suggestion
```
##########
.gitignore:
##########
@@ -55,3 +55,8 @@ dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
ds_schema_check_test
+.claude
Review Comment:
Remove unnessnary change.
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-flink.ts:
##########
@@ -283,6 +283,17 @@ export function useFlink(model: { [field: string]: any }):
IJsonItem[] {
value: model.parallelism
},
useYarnQueue(),
+ {
+ type: 'switch',
+ field: 'shutdownOnAttachedExit',
+ name: t('project.node.shutdown_on_attached_exit'),
+ span: 24,
+ props: {
+ 'checked-value': true,
+ 'unchecked-value': false
+ },
+ value: false // Default: disabled
Review Comment:
```suggestion
value: false
```
Remove unnessary comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
