chris-fast commented on PR #17909:
URL:
https://github.com/apache/dolphinscheduler/pull/17909#issuecomment-3804310666
Hi @SbloodyS , thank you for the review feedback!
I understand the requirement to make the `-sae` parameter configurable in UI
with default as off.
## Current Situation
The current PR removes `-sae` for APPLICATION mode only:
```java
if (deployMode != FlinkDeployMode.APPLICATION) {
args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT);
}
```
## Proposed Solution
I'\''d like to propose adding a **UI-configurable option** for the `-sae`
parameter:
### Implementation Plan
1. **Backend Changes**:
- Add `Boolean shutdownOnAttachedExit` field to `FlinkParameters.java`
- Modify `FlinkArgsUtils.java` to use this config:
```java
if (Boolean.TRUE.equals(flinkParameters.getShutdownOnAttachedExit())) {
args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT);
}
```
- Default value: `null` (disabled, parameter not added)
2. **Frontend Changes**:
- Add a checkbox in Flink task configuration UI
- Label: "Shutdown on Attached Exit" (with tooltip explaining)
- Default: **unchecked** (off by default as requested)
### Benefits
- ✅ User can explicitly control `-sae` parameter
- ✅ Backward compatible (null = no parameter added)
- ✅ Default OFF as requested
- ✅ Clear UI indication
## Questions
Before proceeding with implementation, I'\''d like to confirm:
1. **Default behavior**: Should existing tasks (without this field) have
`-sae` disabled by default?
- My proposal: Yes, default to disabled (null/false)
2. **UI placement**: Should the checkbox be shown for all deploy modes or
only non-APPLICATION modes?
- My proposal: Show for all modes, user has full control
3. **Alternative**: Would you prefer a different approach?
Looking forward to your feedback! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
