ruanwenjun commented on code in PR #18038:
URL:
https://github.com/apache/dolphinscheduler/pull/18038#discussion_r2963519081
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/lifecycle/handler/TaskTimeoutLifecycleEventHandler.java:
##########
@@ -54,6 +54,7 @@ public void handle(final ITaskStateAction taskStateAction,
// The task instance is not active, means it is already finished.
return;
}
+
org.apache.dolphinscheduler.server.master.metrics.TaskMetrics.incTaskInstanceByState("timeout");
Review Comment:
```suggestion
TaskMetrics.incTaskInstanceByState("timeout");
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/AbstractTaskStateAction.java:
##########
@@ -131,6 +133,7 @@ private void persistentTaskInstanceFatalEventToDB(final
ITaskExecutionRunnable t
taskInstance.setState(TaskExecutionStatus.FAILURE);
taskInstance.setEndTime(taskFatalEvent.getEndTime());
taskInstanceDao.updateById(taskInstance);
+ TaskMetrics.incTaskInstanceByState("fail");
Review Comment:
```suggestion
TaskMetrics.incTaskInstanceByState(TaskExecutionStatus.FAILURE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
