SbloodyS commented on code in PR #18038:
URL:
https://github.com/apache/dolphinscheduler/pull/18038#discussion_r3008550180
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/WorkflowEventBusFireWorker.java:
##########
@@ -156,6 +156,40 @@ private void doFireSingleEvent(final
IWorkflowExecutionRunnable workflowExecutio
throw new RuntimeException("No EventHandler found for event: " +
event.getEventType());
}
lifecycleEventHandler.handle(workflowExecutionRunnable, event);
+
+ recordTaskInstanceMetrics(event);
+ }
+
+ private void recordTaskInstanceMetrics(AbstractLifecycleEvent event) {
+ if (!(event
+ .getEventType() instanceof
org.apache.dolphinscheduler.server.master.engine.task.lifecycle.TaskLifecycleEventType))
{
+ return;
+ }
+
+ switch
((org.apache.dolphinscheduler.server.master.engine.task.lifecycle.TaskLifecycleEventType)
event
+ .getEventType()) {
+ case DISPATCHED:
Review Comment:
It's better to store `TaskLifecycleEventType` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
