sanjana2505006 commented on code in PR #18038:
URL:
https://github.com/apache/dolphinscheduler/pull/18038#discussion_r2983805124
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/AbstractTaskStateAction.java:
##########
@@ -131,6 +133,7 @@ private void persistentTaskInstanceFatalEventToDB(final
ITaskExecutionRunnable t
taskInstance.setState(TaskExecutionStatus.FAILURE);
taskInstance.setEndTime(taskFatalEvent.getEndTime());
taskInstanceDao.updateById(taskInstance);
+ TaskMetrics.incTaskInstanceByState("fail");
Review Comment:
All of these direct metric calls inside the state actions have been deleted.
The failure tracking is now natively handled by the event bus worker alongside
the other task events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
