sanjana2505006 commented on code in PR #18038:
URL:
https://github.com/apache/dolphinscheduler/pull/18038#discussion_r2983674141
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/lifecycle/handler/TaskTimeoutLifecycleEventHandler.java:
##########
@@ -54,6 +54,7 @@ public void handle(final ITaskStateAction taskStateAction,
// The task instance is not active, means it is already finished.
return;
}
+
org.apache.dolphinscheduler.server.master.metrics.TaskMetrics.incTaskInstanceByState("timeout");
Review Comment:
I've removed this entirely.
And have deleted this direct metric call and moved the timeout tracking
logic to the event bus worker instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
