caishunfeng commented on a change in pull request #8529:
URL: https://github.com/apache/dolphinscheduler/pull/8529#discussion_r814417890
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1469,8 +1475,6 @@ private ExecutionStatus
getProcessInstanceState(ProcessInstance instance) {
|| CollectionUtils.isNotEmpty(failList)
|| !isComplementEnd()) {
return ExecutionStatus.STOP;
- } else {
- return ExecutionStatus.SUCCESS;
Review comment:
Why to remove this else branch? The state from `READY_STOP` to `SUCCESS`
is possible.
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -455,7 +458,10 @@ private void taskFinished(TaskInstance taskInstance) {
killAllTasks();
}
}
+ } else if (taskInstance.getState().typeIsFinished()) {
Review comment:
When will this branch be taken? Does it need to do others processing?
like task success or fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
