caishunfeng commented on a change in pull request #8529:
URL: https://github.com/apache/dolphinscheduler/pull/8529#discussion_r814426503
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1469,8 +1475,6 @@ private ExecutionStatus
getProcessInstanceState(ProcessInstance instance) {
|| CollectionUtils.isNotEmpty(failList)
|| !isComplementEnd()) {
return ExecutionStatus.STOP;
- } else {
- return ExecutionStatus.SUCCESS;
Review comment:
I think when no kill or failure task, the processInstance state can from
`ready_stop` to `success`.
Otherwise, if no match `STOP` state, it will always keep `READY_STOP`. What
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
