SbloodyS commented on a change in pull request #8529:
URL: https://github.com/apache/dolphinscheduler/pull/8529#discussion_r814420276
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -455,7 +458,10 @@ private void taskFinished(TaskInstance taskInstance) {
killAllTasks();
}
}
+ } else if (taskInstance.getState().typeIsFinished()) {
Review comment:
It will check in
```org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread#getCompleteTaskInstanceMap```
when taskInstance state is cancel(Stop || Kill). This logic exists in 204
branch, but is missing in dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
