SbloodyS commented on a change in pull request #8529:
URL: https://github.com/apache/dolphinscheduler/pull/8529#discussion_r814429187
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1469,8 +1475,6 @@ private ExecutionStatus
getProcessInstanceState(ProcessInstance instance) {
|| CollectionUtils.isNotEmpty(failList)
|| !isComplementEnd()) {
return ExecutionStatus.STOP;
- } else {
- return ExecutionStatus.SUCCESS;
Review comment:
I think of a scenario. When a downstream user uses a dependent node, if
the result of kill command is success, the dependent node will judge that the
execution is successful. In fact, the execution fails, resulting in an error in
the detection result of the dependent node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
