DarkAssassinator commented on issue #12873: URL: https://github.com/apache/dolphinscheduler/issues/12873#issuecomment-1312503443
> > now TaskInstance and TaskDefinition contain environment and cpuQuota and memoryMax, but these shoud be just task params, not task fields. > > LGTM, and now ds has many tasks will run by shell, like spark-cli, flink-cli and so on. They should change together. > > BTW, when delete environment config, it may check whether some tasks use it, so if we remove this field, will it affect query performance? hi @caishunfeng, I understand your concern, but I think this part of the impact is limited for several reasons: 1. These configuration deletion actions are not a frequent operation. 2. We will simplify the deletion logic, check whether the task parameters of the unfinished task instance contain parameters when deleting 3. If query performance bad, we can conside to add index in `task_params` column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
