Radeity commented on issue #12873: URL: https://github.com/apache/dolphinscheduler/issues/12873#issuecomment-1318840439
> > now TaskInstance and TaskDefinition contain environment and cpuQuota and memoryMax, but these shoud be just task params, not task fields. > > LGTM, and now ds has many tasks will run by shell, like spark-cli, flink-cli and so on. They should change together. > > BTW, when delete environment config, it may check whether some tasks use it, so if we remove this field, will it affect query performance? Hi, @caishunfeng @DarkAssassinator BTW, i think current table structure of `t_ds_environment` is not elegant, as far as I know, environment just configure some environment variables which may be used in tasks. Why not record a variable in one row, rather use `config` field? Only query this table once during task execution, so query performance is not a big deal. Also, i have an environment-related question, in https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1317967932, wish you could give some suggestions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
