DarkAssassinator commented on issue #12873: URL: https://github.com/apache/dolphinscheduler/issues/12873#issuecomment-1324983192
> > Hi, @caishunfeng @DarkAssassinator BTW, i think current table structure of `t_ds_environment` is not elegant, as far as I know, environment just configure some environment variables which may be used in tasks. Why not record a variable in one row, rather use `config` field? Only query this table once during task execution, so query performance is not a big deal. > > Also, i have an environment-related question, in [#12713 (comment)](https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1317967932), wish you could give some suggestions! > > Oh, i just find that config is directly written into command file, if so, save it as String is more convenient. hi @Radeity because many task may use the same environment, so DS add `t_ds_environment` to manage. So u mean that we should add a environment string column in task_instance? But I think the environemt field is only useful for some tasks that use bash, not all task types, so I think the environemt field does not belong to the taskInstance, but should be a custom parameter of the task plugins. So we should abstract task custom parameter to a other db table to inrease query performance. WDYT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
